Further changes and new tests

cli/cliopts/edit.go

@@ -9,15 +9,12 @@ import (
 )
 
 func EditOption() bool {
-	ListOption("")
 	err := ngops.Edit(getEditInfo())
 
 	if err != nil {
 		styles.ShowAsError(ng.Config.Colors, "Unable to edit task", err.Error())
 	}
 
-	ListOption("")
-
 	return false
 }
 

cli/cliopts/help.go

@@ -1,8 +1,6 @@
 package cliopts
 
 import (
-	"fmt"
-
 	"github.com/leo-alvarenga/to-go/cli/clihelper"
 	"github.com/leo-alvarenga/to-go/ng"
 	"github.com/leo-alvarenga/to-go/shared/styles"
@@ -20,7 +18,7 @@ func HelpMessage() bool {
 }
 
 func InvalidOptionAlert(input string) bool {
-	fmt.Printf("\"%s\" is not a valid option!\n\n", input)
+	styles.ShowAsError(ng.Config.Colors, "\""+input+"\" is not a valid option", "")
 
 	return HelpMessage()
 }

main.go

@@ -1,13 +1,11 @@
 package main
 
 import (
-	"fmt"
 	"os"
 
 	"github.com/leo-alvarenga/to-go/cli"
 )
 
 func main() {
-	fmt.Println("ok")
 	cli.Entrypoint(os.Args)
 }

ng/ngops/edit.go

@@ -19,7 +19,7 @@ func Edit(n, old task.Task) error {
 
 	err := ng.TaskList.Edit(old, n)
 	if err != nil {
-		return nil
+		return err
 	}
 
 	return writeToYamlWrapper()

ng/storage/yaml.go

@@ -70,5 +70,7 @@ func RetrieveTasksFromYaml(taskFilenames [3]string, list *task.TaskList) error {
 		)
 	}
 
+	list.SyncNextId()
+
 	return nil
 }

shared/cfg/cfg.go

@@ -32,16 +32,14 @@ type ColorScheme struct {
 }
 
 type ConfigValue struct {
-	UseUnicode     bool        `yaml:"useUnicode"`
-	Storage        string      `yaml:"storage"`
-	TasksOlderThan int         `yaml:"tasksOlderThan"`
-	Colors         ColorScheme `yaml:"colors"`
+	UseUnicode bool        `yaml:"useUnicode"`
+	Storage    string      `yaml:"storage"`
+	Colors     ColorScheme `yaml:"colors"`
 }
 
 func (cfg *ConfigValue) New() {
 	cfg.UseUnicode = true
 	cfg.Storage = "sqlite"
-	cfg.TasksOlderThan = 10
 	cfg.Colors = ColorScheme{
 		Priority: PriorityColor{
 			High:   "red",

shared/task/task_list.go

@@ -9,13 +9,21 @@ type TaskList struct {
 	Low    *[]Task
 	Medium *[]Task
 	High   *[]Task
+	nextId int
 }
 
 /* Initializes a newly allocated TaskList */
 func (t *TaskList) New() {
 	t.Low = new([]Task)
 	t.Medium = new([]Task)
 	t.High = new([]Task)
+
+	t.nextId = 0
+}
+
+/* Updates the value meant to be the next task id */
+func (t *TaskList) SyncNextId() {
+	t.nextId = (len(*t.High) + len(*t.Medium) + len(*t.Low)) - 3
 }
 
 /* Empty one of the slices, based on the 'priority' parameter */
@@ -84,7 +92,6 @@ func (t *TaskList) GetTaskByTitle(title string) (Task, error) {
 }
 
 /* Finds the index of the 'ts' Task; Returns an index of -1 and an error if it could not be found  */
-// todo -> make so ids aare unique, even in yaml mode
 func (t *TaskList) FindIndex(ts Task) (int, error) {
 	if !IsThisAPriority(ts.Priority) {
 		return -1, errors.New("Task does not have a valid priority.")
@@ -122,16 +129,18 @@ func (t *TaskList) Add(ts Task) error {
 
 	switch ts.Priority {
 	case high:
-		ts.Id = len((*t.High))
+		ts.Id = t.nextId
 		(*t.High) = append((*t.High), ts)
 	case medium:
-		ts.Id = len((*t.Medium))
+		ts.Id = t.nextId
 		(*t.Medium) = append((*t.Medium), ts)
 	case low:
-		ts.Id = len((*t.Low))
+		ts.Id = t.nextId
 		(*t.Low) = append((*t.Low), ts)
 	}
 
+	t.nextId++
+
 	return nil
 }
 

shared/task/task_test.go

@@ -35,3 +35,77 @@ func TestIsThisAPriority(t *testing.T) {
 		t.Errorf("With argument '%s':\nExpected 'true'; Got 'false'", arg)
 	}
 }
+
+func TestTaskListOps(t *testing.T) {
+	task := Task{
+		Title:       "ok",
+		Description: "",
+		Priority:    "",
+	}
+
+	list := new(TaskList)
+	list.New()
+
+	t.Log("Adding task with no priority...")
+	err := list.Add(task)
+
+	if err == nil {
+		t.Error("Expected error when adding task with no priority; Got nil")
+	}
+
+	task.Priority = low
+	t.Log("Adding task with priority...")
+	err = list.Add(task)
+
+	if err != nil {
+		t.Errorf("Expected no error; Got '%s'\n", err.Error())
+	}
+
+	task.Status = done
+	t.Log("Updating task status...")
+	err = list.Update(task)
+
+	if err != nil {
+		t.Errorf("Expected no error; Got '%s'\n", err.Error())
+	}
+
+	if (*list.Low)[0].Status != done {
+		t.Errorf("Expected status od 'done' after update; Got '%s'\n", (*list.Low)[0].Status)
+	}
+
+	t.Log("Removing task...")
+	err = list.Remove(task.Title)
+
+	if err != nil {
+		t.Errorf("Expected no error; Got '%s'\n", err.Error())
+	}
+
+	if len(*list.Low) > 0 {
+		t.Errorf("Expected length of 0 after removal; Got '%d'\n", len(*list.Low))
+	}
+
+	task.Priority = medium
+	t.Log("Adding task with priority again...")
+	err = list.Add(task)
+
+	if err != nil {
+		t.Errorf("Expected no error; Got '%s'\n", err.Error())
+	}
+
+	old := task
+	task.Title = "a"
+	task.Priority = high
+
+	t.Log("Editing task priority and title...")
+	err = list.Edit(old, task)
+
+	if err != nil {
+		t.Errorf("Expected no error; Got '%s'\n", err.Error())
+	}
+
+	if len(*list.Medium) > len(*list.High) {
+		t.Errorf("Expected to change the task priority; Got '%s' instead", (*list.Medium)[0].Priority)
+	} else if (*list.High)[0].Title != task.Title {
+		t.Errorf("Expected to change the task title; Expected '%s'; Got '%s' instead", task.Title, (*list.High)[0].Title)
+	}
+}