Mouse buttons are set to autorepeat

[agoode]

When I use evtest, I get this:

Event: time 1414638611.239038, type 4 (EV_MSC), code 4 (MSC_SCAN), value 90001
Event: time 1414638611.239038, type 1 (EV_KEY), code 272 (BTN_LEFT), value 1
Event: time 1414638611.239038, -------------- SYN_REPORT ------------
Event: time 1414638611.488596, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.488596, -------------- SYN_REPORT ------------
Event: time 1414638611.521540, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.521540, -------------- SYN_REPORT ------------
Event: time 1414638611.554536, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.554536, -------------- SYN_REPORT ------------
Event: time 1414638611.587540, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.587540, -------------- SYN_REPORT ------------
Event: time 1414638611.620542, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.620542, -------------- SYN_REPORT ------------
Event: time 1414638611.653542, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.653542, -------------- SYN_REPORT ------------
Event: time 1414638611.686542, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.686542, -------------- SYN_REPORT ------------
Event: time 1414638611.719543, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.719543, -------------- SYN_REPORT ------------
Event: time 1414638611.752542, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.752542, -------------- SYN_REPORT ------------
Event: time 1414638611.785557, type 1 (EV_KEY), code 272 (BTN_LEFT), value 2
Event: time 1414638611.785557, -------------- SYN_REPORT ------------
Event: time 1414638611.815027, type 4 (EV_MSC), code 4 (MSC_SCAN), value 90001
Event: time 1414638611.815027, type 1 (EV_KEY), code 272 (BTN_LEFT), value 0
Event: time 1414638611.815027, -------------- SYN_REPORT ------------

Probably it's this line in hid-lenovo.c (line 65):
set_bit(EV_REP, hi->input->evbit);

Probably you want to only set this conditionally.

[lentinj]

Line 65 is only for the vendor-specific pages, which the mouse buttons shouldn't be part of. However, it's likely to be something along these lines.

You have the USB version, yes?

[agoode]

Yes, the USB version. This behavior does not occur with the generic HID driver, nor with my other mouse devices.

[lentinj]

It's the same on both the BT and USB keyboards. set_bit is probably working for the device as a whole, which if you have a separate keyboard and mouse device is fine. However, we don't.

[lentinj]

Yes it is. Removing it means that for the USB keyboard you get no key repeat on the mouse buttons or the hotkeys, but do on the regular keys. This seems fine.

However, the problem still persists with the bluetooth keyboard, since there is only one device, and other usage pages cause EV_REP to be turned on for it.

[agoode]

Does the bluetooth version show keyrepeat on the mouse buttons with the generic driver?

[lentinj]

Yes (at least at work on 3.16). The Bluetooth keyboard isn't divided into keyboard / mouse + hotkey devices like the USB one. So when the kernel finds a keyboard usage page, EV_REP gets turned on for the whole thing, mouse buttons and all.

[lentinj]

The following patch was accepted upstream, which fixes the USB keyboard

https://github.com/lentinj/tp-compact-keyboard/blob/master/kernel-patch/1002-HID-lenovo-Don-t-set-EV_REP-to-avoid-repeating-mice-.patch