Skip to content

Use SciPy LAPACK to simplify Rust dependency stack#960

Merged
mdekstrand merged 11 commits intolenskit:future/2026from
mdekstrand:tweak/simplify-rust
Nov 25, 2025
Merged

Use SciPy LAPACK to simplify Rust dependency stack#960
mdekstrand merged 11 commits intolenskit:future/2026from
mdekstrand:tweak/simplify-rust

Conversation

@mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Nov 24, 2025

This removes nalgebra, instead using the sposv LAPACK function through SciPy, simplifying the Rust dependency stack.

It also adds a general function for extracting Cython CABI function pointers that can be used to access additional BLAS and LAPACK functions in the future, if needed.

@mdekstrand mdekstrand added this to the 2026.1 milestone Nov 24, 2025
@mdekstrand mdekstrand added the dependencies Pull requests that update a dependency file label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 85.29412% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.90%. Comparing base (f3455da) to head (902d09f).
⚠️ Report is 11 commits behind head on future/2026.

Files with missing lines Patch % Lines
src/accel/als/solve.rs 79.16% 10 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           future/2026     #960      +/-   ##
===============================================
- Coverage        88.94%   88.90%   -0.04%     
===============================================
  Files              215      217       +2     
  Lines            14961    15012      +51     
===============================================
+ Hits             13307    13347      +40     
- Misses            1654     1665      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand mdekstrand changed the title Use ndarray-linalg to simplify Rust dependency stack Use SciPy LAPACK to simplify Rust dependency stack Nov 25, 2025
@mdekstrand mdekstrand self-assigned this Nov 25, 2025
@mdekstrand mdekstrand merged commit 902d09f into lenskit:future/2026 Nov 25, 2025
38 of 40 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in LensKit Development Nov 25, 2025
@mdekstrand mdekstrand deleted the tweak/simplify-rust branch November 25, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Development

Successfully merging this pull request may close these issues.

1 participant