Refactor embedding size configuration for consistency + exponential support - #851
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 89.82% 89.83%
=======================================
Files 157 158 +1
Lines 11193 11202 +9
=======================================
+ Hits 10054 10063 +9
Misses 1139 1139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdekstrand
force-pushed
the
feature/embedding-size-exp
branch
from
September 29, 2025 16:58
ac6bed5 to
eaeaf1f
Compare
mdekstrand
force-pushed
the
feature/embedding-size-exp
branch
from
September 30, 2025 16:32
ad1092a to
3a15c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the idea of “common configuration mixins”, to define common behavior across multiple configuration classes, and defines one for
embedding_size, that has the useful behavior of supporting anembedding_size_expalias to specify the embedding size as a power of 2.