Skip to content

Refactor embedding size configuration for consistency + exponential support - #851

Merged
mdekstrand merged 16 commits into
lenskit:mainfrom
mdekstrand:feature/embedding-size-exp
Oct 1, 2025
Merged

Refactor embedding size configuration for consistency + exponential support#851
mdekstrand merged 16 commits into
lenskit:mainfrom
mdekstrand:feature/embedding-size-exp

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

This adds the idea of “common configuration mixins”, to define common behavior across multiple configuration classes, and defines one for embedding_size, that has the useful behavior of supporting an embedding_size_exp alias to specify the embedding size as a power of 2.

@mdekstrand mdekstrand added this to the 2025.3 milestone Sep 29, 2025
@mdekstrand mdekstrand self-assigned this Sep 29, 2025
@mdekstrand mdekstrand added the components LensKit recommendation components label Sep 29, 2025
@mdekstrand mdekstrand moved this from Backlog to In Progress in LensKit Development Sep 29, 2025
@codecov

codecov Bot commented Sep 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.83%. Comparing base (763dbb6) to head (72b8064).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/lenskit/logging/progress/_rich.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   89.82%   89.83%           
=======================================
  Files         157      158    +1     
  Lines       11193    11202    +9     
=======================================
+ Hits        10054    10063    +9     
  Misses       1139     1139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand
mdekstrand force-pushed the feature/embedding-size-exp branch from ac6bed5 to eaeaf1f Compare September 29, 2025 16:58
@mdekstrand
mdekstrand force-pushed the feature/embedding-size-exp branch from ad1092a to 3a15c1a Compare September 30, 2025 16:32
@mdekstrand
mdekstrand merged commit 72b8064 into lenskit:main Oct 1, 2025
33 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LensKit Development Oct 1, 2025
@mdekstrand
mdekstrand deleted the feature/embedding-size-exp branch October 1, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components LensKit recommendation components

Projects

Development

Successfully merging this pull request may close these issues.

1 participant