Skip to content

refactor FlexMF with less string compares - #752

Merged
mdekstrand merged 1 commit into
lenskit:mainfrom
mdekstrand:tweak/speedup-flex-compare
May 14, 2025
Merged

refactor FlexMF with less string compares#752
mdekstrand merged 1 commit into
lenskit:mainfrom
mdekstrand:tweak/speedup-flex-compare

Conversation

@mdekstrand

@mdekstrand mdekstrand commented May 14, 2025

Copy link
Copy Markdown
Member

This refactors FlexMF's tight loops to reduce string comparisons.

@mdekstrand mdekstrand added performance components LensKit recommendation components labels May 14, 2025
@mdekstrand mdekstrand added this to the 2025.3 milestone May 14, 2025
@mdekstrand
mdekstrand merged commit 04151df into lenskit:main May 14, 2025
@mdekstrand
mdekstrand deleted the tweak/speedup-flex-compare branch May 14, 2025 02:25
@codecov

codecov Bot commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (08d2b94) to head (eebe122).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   90.17%   90.03%   -0.14%     
==========================================
  Files         138      138              
  Lines        9799     9813      +14     
==========================================
- Hits         8836     8835       -1     
- Misses        963      978      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components LensKit recommendation components performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant