Skip to content

Add Rust acceleration to User KNN - #730

Merged
mdekstrand merged 10 commits into
lenskit:mainfrom
mdekstrand:feature/accelerate-uknn
Apr 23, 2025
Merged

Add Rust acceleration to User KNN#730
mdekstrand merged 10 commits into
lenskit:mainfrom
mdekstrand:feature/accelerate-uknn

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

This rewrites User KNN scoring in Rust, and uses SciPy instead of Torch for similarities. This also removes the last need for some of the Torch sparse matrix normalization code.

Closes #718.

@mdekstrand mdekstrand added components LensKit recommendation components performance labels Apr 23, 2025
@mdekstrand mdekstrand added this to the 2025.3 milestone Apr 23, 2025
@codecov

codecov Bot commented Apr 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (868d3aa) to head (a334288).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   90.36%   90.35%   -0.01%     
==========================================
  Files         137      137              
  Lines        9741     9694      -47     
==========================================
- Hits         8802     8759      -43     
+ Misses        939      935       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdekstrand
mdekstrand merged commit a6ed0a1 into lenskit:main Apr 23, 2025
@mdekstrand
mdekstrand deleted the feature/accelerate-uknn branch May 14, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

components LensKit recommendation components performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accelerate User KNN

1 participant