Skip to content

Improve logging in Ray cluster setups - #673

Merged
mdekstrand merged 11 commits into
lenskit:mainfrom
mdekstrand:fix/cluster-logging
Mar 23, 2025
Merged

Improve logging in Ray cluster setups#673
mdekstrand merged 11 commits into
lenskit:mainfrom
mdekstrand:fix/cluster-logging

Conversation

@mdekstrand

Copy link
Copy Markdown
Member

This adds several improvements and bug-fixes for subprocess logging when running in a Ray cluster.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Mar 23, 2025
@mdekstrand mdekstrand added this to the 2025.3 milestone Mar 23, 2025
@codecov

codecov Bot commented Mar 23, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (f877fd3) to head (2085049).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/lenskit/parallel/ray.py 33.33% 10 Missing ⚠️
src/lenskit/logging/monitor.py 0.00% 1 Missing ⚠️
src/lenskit/logging/worker.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   91.03%   90.96%   -0.08%     
==========================================
  Files         132      132              
  Lines        9078     9096      +18     
==========================================
+ Hits         8264     8274      +10     
- Misses        814      822       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdekstrand
mdekstrand merged commit 2085049 into lenskit:main Mar 23, 2025
@mdekstrand
mdekstrand deleted the fix/cluster-logging branch March 23, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internals Internal infrastructure (parallelism, math, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant