Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split implicit wrappers into new package #281

Merged
merged 3 commits into from
Oct 24, 2021

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Oct 23, 2021

This splits the implicit wrappers into a separate lenskit-implicit package.

@mdekstrand mdekstrand added this to the 0.14.0 milestone Oct 23, 2021
@mdekstrand mdekstrand added the algorithms LensKit algorithm implementations label Oct 23, 2021
@codeclimate
Copy link

codeclimate bot commented Oct 23, 2021

Code Climate has analyzed commit 28822ff and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #281 (28822ff) into main (76bd820) will increase coverage by 2.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   89.10%   91.53%   +2.43%     
==========================================
  Files          43       43              
  Lines        3459     3391      -68     
==========================================
+ Hits         3082     3104      +22     
+ Misses        377      287      -90     
Impacted Files Coverage Δ
lenskit/algorithms/implicit.py 0.00% <0.00%> (-27.54%) ⬇️
lenskit/algorithms/svd.py 95.23% <0.00%> (+65.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76bd820...28822ff. Read the comment docs.

@mdekstrand mdekstrand merged commit 752c855 into lenskit:main Oct 24, 2021
@mdekstrand mdekstrand deleted the feature/split-implicit branch October 24, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithms LensKit algorithm implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant