Skip to content

Change from pre-commit to hk and update dev setup instructions - #1135

Merged
mdekstrand merged 26 commits into
lenskit:mainfrom
mdekstrand:tweak/hk
Jul 10, 2026
Merged

Change from pre-commit to hk and update dev setup instructions#1135
mdekstrand merged 26 commits into
lenskit:mainfrom
mdekstrand:tweak/hk

Conversation

@mdekstrand

@mdekstrand mdekstrand commented Jul 3, 2026

Copy link
Copy Markdown
Member

This has some dev environment updates:

  • Change from pre-commit to hk
  • Update and fix dev container
  • Update README.md to reflect current setup
  • Add CI job to verify the dev container still works

@mdekstrand mdekstrand self-assigned this Jul 3, 2026
@mdekstrand mdekstrand added the build Build, test, and platform support label Jul 3, 2026
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.55%. Comparing base (c556385) to head (28edce5).

Files with missing lines Patch % Lines
src/accel/als/solve.rs 83.33% 1 Missing ⚠️
src/accel/arrow/types/index_list.rs 0.00% 1 Missing ⚠️
src/accel/arrow/types/row.rs 50.00% 1 Missing ⚠️
src/accel/data/index.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files         256      256           
  Lines       17274    17276    +2     
=======================================
+ Hits        15469    15471    +2     
  Misses       1805     1805           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand
mdekstrand force-pushed the tweak/hk branch 3 times, most recently from 9d8031f to e177daf Compare July 10, 2026 18:11
@mdekstrand mdekstrand changed the title Change from pre-commit to hk Change from pre-commit to hk and update dev setup instructions Jul 10, 2026
@mdekstrand mdekstrand moved this from Backlog to In Progress in LensKit Development Jul 10, 2026
@mdekstrand
mdekstrand marked this pull request as ready for review July 10, 2026 19:07
@mdekstrand
mdekstrand merged commit 28edce5 into lenskit:main Jul 10, 2026
38 of 40 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LensKit Development Jul 10, 2026
@mdekstrand
mdekstrand deleted the tweak/hk branch July 10, 2026 21:07
@mdekstrand mdekstrand added this to the 2026.3 milestone Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build, test, and platform support

Projects

Development

Successfully merging this pull request may close these issues.

1 participant