Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject Host header to k8s client requests #887

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Inject Host header to k8s client requests #887

merged 3 commits into from
Sep 16, 2020

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Sep 15, 2020 •
edited
Loading

Alternative to #884.

Aims to fix #873.

TODO:

  • fix kubectl in terminal

@jakolehm
fix rancher on kubernetes
4c182e8 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm changed the title Explicitly add Host header to k8s client requests Inject Host header to k8s client requests Sep 15, 2020
@jakolehm
redirect spdy to kubectl-auth-proxy
ae6771c 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm marked this pull request as ready for review September 16, 2020 08:03
@jakolehm jakolehm requested a review from nevalla September 16, 2020 08:03
@jakolehm jakolehm added the bug Something isn't working label Sep 16, 2020
@jakolehm
Copy link
Contributor Author

Now only kubectl exec has issues when kubernetes api is behind a proxy that does routing based on "Host" header. Not perfect but at least cluster dashboard is functional.

ixrock
ixrock reviewed Sep 16, 2020
View reviewed changes
ixrock
ixrock reviewed Sep 16, 2020
View reviewed changes
@nevalla nevalla mentioned this pull request Sep 16, 2020
Closed
3 tasks
@jakolehm
cleanup
4e57ea7 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added this to the 3.6.1 milestone Sep 16, 2020
nevalla
nevalla approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit c2afd02 into master Sep 16, 2020
@jakolehm jakolehm deleted the fix/rancher-on-kubernetes branch September 16, 2020 17:54
This was referenced Sep 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixrock ixrock ixrock left review comments

@Nokel81 Nokel81 Nokel81 left review comments

@nevalla nevalla nevalla approved these changes

@jim-docker jim-docker Awaiting requested review from jim-docker

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Unable to connect to Rancher clusters after upgrading to v3.6.0
4 participants
@jakolehm @nevalla @ixrock @Nokel81