Quick fix for store migration version being wrong #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
jansav and
aleksfront
and removed request for
a team
jim-docker
reviewed
Feb 27, 2023
| import { getInjectable } from "@ogre-tools/injectable"; | ||
|
|
||
| const storeMigrationVersionInjectable = getInjectable({ | ||
| id: "store-migration-version", | ||
| instantiate: (di) => di.inject(applicationInformationToken).version, | ||
| instantiate: () => "6.4.0", |
There was a problem hiding this comment.
Could this remain as di.inject(applicationInformationToken).version unless it is not our usual versioning value. Can you easily detect when di.inject(applicationInformationToken).version is unusual?
jim-docker
approved these changes
Feb 27, 2023
jakolehm
reviewed
Feb 28, 2023
| import { getInjectable } from "@ogre-tools/injectable"; | ||
|
|
||
| const storeMigrationVersionInjectable = getInjectable({ | ||
| id: "store-migration-version", | ||
| instantiate: (di) => di.inject(applicationInformationToken).version, | ||
| instantiate: () => "6.4.0", |
There was a problem hiding this comment.
instantiate: (di) => di.inject(extensionApiVersionInjectable)
Nokel81
added a commit
that referenced
this pull request
Mar 1, 2023
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Merged
Nokel81
added a commit
that referenced
this pull request
Mar 1, 2023
* General fixes for release-tool (#7238) * General fixes for release-tool Signed-off-by: Sebastian Malton <sebastian@malton.name> * Revert change to number of PRs retrieved Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name> * Throw on errors in kubectlApplyFolder (#7239) Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com> * Quick fix for store migration version being wrong (#7243) Signed-off-by: Sebastian Malton <sebastian@malton.name> * Revert "Renderer file logging transport (#6795)" (#7245) Renderer file logging still caused UI freezing (at least on apple silicon macs) when cluster frame was open and main frame was reloaded. See #544 This reverts commit ac2d0e4. Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> * Fix extension install (#7247) * Fix extension install - Remove old bundled extension dependencies - Make sure external extensions are installed as optional Signed-off-by: Sebastian Malton <sebastian@malton.name> * Ignore ENOENT errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add comment Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name> * Release 6.4.0 Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> --------- Signed-off-by: Sebastian Malton <sebastian@malton.name> Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com> Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com> Co-authored-by: Panu Horsmalahti <phorsmalahti@mirantis.com> Co-authored-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/lensapp/lens-ide/issues/529
Better version is in #4571, which makes the migration version specific to each store.