Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dashboard server logic to electron main #146

Merged
merged 8 commits into from
Mar 24, 2020

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Mar 23, 2020

This simplifies architecture and build pipeline a lot. No more separate server binary (and process) for each cluster dashboard.

Fixes #140
Fixes #117

@jakolehm jakolehm added the enhancement New feature or request label Mar 23, 2020
@jakolehm jakolehm added this to the 3.1.0 milestone Mar 23, 2020
@jakolehm jakolehm requested a review from a team March 23, 2020 15:54
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm force-pushed the move-server-routes-to-main branch from aa59c2f to 8e25991 Compare March 23, 2020 15:55
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Copy link
Member

@miskun miskun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but I'm able to test this only on Mac

@jakolehm jakolehm merged commit 1aaa695 into master Mar 24, 2020
@jakolehm jakolehm deleted the move-server-routes-to-main branch March 24, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object watches are broken in 1.15 kubernetes Refresh lists doesn't work
2 participants