Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry cap to handleStaticFile to prevent an infitite loop #1373

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Nov 13, 2020

Signed-off-by: Sebastian Malton sebastian@malton.name

This is a fix followup to #1250 which sometimes can cause an infinite loop during loading if LensDev.html was not generated recently.

@Nokel81 Nokel81 added the bug Something isn't working label Nov 13, 2020
@Nokel81 Nokel81 requested review from chenhunghan and a team November 13, 2020 15:12
@Nokel81 Nokel81 self-assigned this Nov 13, 2020
Copy link
Contributor

@chenhunghan chenhunghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good for me

Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 merged commit 4d32047 into master Nov 13, 2020
@Nokel81 Nokel81 deleted the fix-infite-loop branch November 13, 2020 20:46
@jakolehm jakolehm mentioned this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants