Keeping Icon focus state only for keyboard #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
suggested changes
Nov 5, 2020
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
|
@ixrock Please do re-review. Replaced custom solution with |
ixrock
approved these changes
Nov 10, 2020
Merged
pauljwil
pushed a commit
to pauljwil/lens
that referenced
this pull request
Nov 11, 2020
* Passing toolbar prop into action menus Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Toggling .mouse-intent Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Icon focus restyling Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Adding what-input dependency Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
:focusstyles for<Icon />component when using mouse. This fixes issue when Icon seems frozen in hover state even if cursor went away.Determining mouse/keyboard usage by toggling
.mouse-intentclass name onbodyelement.Added outline styling for Icon's
:focusstate.Close #1228