refactor: ProfileFollowModule revision number logic discarded#128
Merged
Conversation
donosonaumczuk
commented
May 10, 2022
| /** | ||
| * Given two profile IDs tells if the former has already been used to follow the latter. | ||
| */ | ||
| mapping(uint256 => mapping(uint256 => bool)) public isProfileFollowing; |
Contributor
Author
There was a problem hiding this comment.
@Zer0dot Anticipating your thoughts, maybe you would prefer isFollowingByFollowerProfileIdByFollowedProfieId or something like that here.
I did it this way because I did the mapping public so can be used as getter like isProfileFollowing(followerProfileId, followedProfileId) and in the code looks also clear, plus is only used in one part of the code which is super simple.
donosonaumczuk
pushed a commit
that referenced
this pull request
Oct 20, 2023
…-collect Test/fix wrong currency in collect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.