Including csv External sorting using apache commons #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including new class to deal with CsvExternal sorting using apache commons csv
|
This pull request introduces 2 alerts when merging 87ed0bc into 8edf467 - view on LGTM.com new alerts:
|
|
@guilhermefaleixo Can you review the warnings at LGTM And make sure that they are not a concern? |
|
Hello @lemire the LGTM is down right now, but one of the issues is the inputStream that is not closed but it is the same code that you have in that part and the second issue as far as I am concern it is not an issue as it will be closed anyway when the parser is closed. |
|
Ok. Let us merge. |
|
Thank you so much for your great work @lemire , your library helped me a lot and I hope that this CSV version of it can help as much as helped me =D |
|
Thanks for your great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including new class to deal with CsvExternal sorting using apache commons csv
I made small changes into your logic to be able to work with csv files better.