Open
Conversation
DavidSGK
reviewed
Feb 28, 2024
Member
DavidSGK
left a comment
DavidSGK
left a comment
There was a problem hiding this comment.
Awesome if this deals with all of the use cases, but isn't there a bit of a difference with the previous approach? Previously we got a config evaluation regardless of context but now we only get placeholder data if a query with the same context is in the history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the placeholder data to just use the previous data from the function rather than getting it from a cache.
Not sure about the need for NonFunction guard