Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base url note #135

Merged
merged 1 commit into from
May 8, 2020
Merged

Base url note #135

merged 1 commit into from
May 8, 2020

Conversation

JEuler
Copy link
Collaborator

@JEuler JEuler commented Apr 25, 2020

No description provided.

@JEuler JEuler requested review from stewemetal and lejard-h April 25, 2020 06:18
@JEuler JEuler mentioned this pull request Apr 25, 2020
@JEuler
Copy link
Collaborator Author

JEuler commented Apr 26, 2020

@stewemetal All is okay now? :)

@JEuler
Copy link
Collaborator Author

JEuler commented May 5, 2020

@stewemetal ? :) Maybe @lejard-h ? :)

Copy link
Owner

@lejard-h lejard-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
I will merge in master after this one to update the doc

Copy link
Collaborator

@stewemetal stewemetal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

faq.md Outdated
@@ -61,6 +62,20 @@ Request compressRequest(Request request) {
Future<Response> postRequest(@Body() Map<String, String> data);
```

## Runtime baseUrl change

You may need to change the base URL of your network calls during runtime, for example, if you have to use different servers or routes dynamically in your app in case of a "regular" or a "paid" user. You can store the current server base url in your SharedPreferences (encrypt/decrypt it if needed) and use in interceptor like that:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little adjustment:
"use in interceptor like that:" -> "use it in an interceptor like this:"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added your note! And squashed commits.

Runtime base url note update

Update faq.md
@JEuler JEuler merged commit 96c17ef into develop May 8, 2020
@JEuler JEuler deleted the base-url-note branch May 8, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants