fix: Add break to saunafs infinite loop on Windows

[rolysr]

Previous version of the saunafs binary on Windows had an infinite loop every time it was executed on a filesystem that was not SaunaFS. This commit solves this issue.

[gemini-code-assist]

Hello @rolysr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an infinite loop issue in the SaunaFS binary on Windows. According to the description, the previous version would enter an infinite loop when executed on a non-SaunaFS filesystem. To fix this, I've added a retry mechanism with a maximum number of retries (kMaxMasterRetries) and a short sleep between retries. This prevents the infinite loop and returns an error if the filesystem is not recognized as SaunaFS after several attempts.

Highlights

• Windows-specific fix: The changes are conditionally compiled for Windows using #ifdef _WIN32.
• Retry mechanism: A retry counter (master_conn_retries) and a maximum retry limit (kMaxMasterRetries) are introduced to prevent infinite loops when the filesystem is not SaunaFS.
• Error handling: After exceeding the maximum retries, the function now returns an error indicating that the object is not a SaunaFS object.

Changelog

• src/tools/master_functions.cc
  • Added #ifdef _WIN32 block to define kMaxMasterRetries constant.
  • Added master_conn_retries variable to track the number of connection attempts.
  • Implemented a retry loop with a maximum retry count and a sleep between retries.
  • Added a check to exit the loop and return an error if kMaxMasterRetries is exceeded.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

On Windows, a loop unending,
SaunaFS, its fate was bending.
A retry's grace,
A limit in place,
Now errors, the system is sending.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an infinite loop issue in the SaunaFS binary on Windows. The changes introduce a retry mechanism with a maximum number of retries to prevent the loop. The solution appears reasonable, but I have a few suggestions to improve the code's clarity and robustness.

Summary of Findings

• Magic Number: The value 5 is used as the maximum number of retries. It would be better to define this as a constant with a descriptive name to improve readability and maintainability.
• Error Message Clarity: The error message "not SaunaFS object" could be more informative. Consider including the path being checked to help users diagnose the issue.
• Sleep Duration: The sleep duration increases with each retry. This might lead to long delays if the issue persists. Consider using a fixed or capped sleep duration.

Merge Readiness

The pull request addresses a critical issue and should be merged after addressing the comments. The changes seem to resolve the infinite loop, but the suggestions aim to improve the code's maintainability and user experience. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. At a minimum, the high severity issues should be addressed before merging.

[Copilot]

Pull Request Overview

This pull request fixes an infinite loop issue on Windows when executing the saunafs binary on a non-SaunaFS filesystem. Key changes include adding a Windows-specific maximum retry limit, introducing a retry counter, and incorporating a delay to break the infinite loop.

Comments suppressed due to low confidence (2)

src/tools/master_functions.cc:55

• [nitpick] Consider defining kMaxMasterRetries as a constant (e.g., static const int kMaxMasterRetries = 5;) to prevent accidental modification.

static int kMaxMasterRetries = 5;

src/tools/master_functions.cc:428

• [nitpick] Using master_conn_retries as the sleep duration may not produce the intended delay pattern. Consider using a fixed delay or a more explicit backoff strategy for clarity and effectiveness.

sleep(master_conn_retries);