feat: Log error_code related message

[ictus4u]

Provide more context about the triggered error.

[gemini-code-assist]

Hello @ictus4u, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request enhances error logging within the ChunkTrashManager and ChunkTrashManagerImpl classes. The primary change involves replacing calls to safs::log_err with safs::log_error_code, providing more context about the triggered errors by including the error code and message in the log output. This change affects several functions within ChunkTrashManager and ChunkTrashManagerImpl, ensuring consistent and informative error logging throughout the trash management process. Additionally, the pull request removes the experimental logging functions from chunk_trash_manager_impl.cc and adds #include "errors/saunafs_error_codes.h" to slogger/slogger.h.

Highlights

• Enhanced Error Logging: Replaced safs::log_err with safs::log_error_code to include error codes in log messages for better context.
• Code Cleanup: Removed experimental logging functions from chunk_trash_manager_impl.cc.
• Dependency Management: Added #include "errors/saunafs_error_codes.h" to slogger/slogger.h to ensure error codes are available for logging.

Changelog

• src/chunkserver/chunkserver-common/chunk_trash_manager.cc
  • Replaced safs::log_err with safs::log_error_code to include error codes in log messages.
• src/chunkserver/chunkserver-common/chunk_trash_manager_impl.cc
  • Removed experimental logging functions.
  • Replaced safs::log_err with safs::log_error_code to include error codes in log messages.
• src/chunkserver/chunkserver-common/cmr_disk.cc
  • Replaced safs_pretty_errlog with safs::log_error_code to include error codes in log messages.
• src/slogger/slogger.h
  • Added #include "errors/saunafs_error_codes.h" to ensure error codes are available.
  • Added log_error_code template functions for std::error_code, saunafs_error_code, and int (errno).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

In realms of code, where errors reside,
Logs now speak with error codes tied.
Context clear and bright,
Aiding swift insight,
Debugging's path, now open wide.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new logging mechanism using safs::log_error_code to provide more context about triggered errors in the ChunkTrashManager. The changes look good overall, but there are a few areas where improvements can be made to enhance code clarity and maintainability.

Summary of Findings

• Consistency in error handling: The changes consistently replace safs::log_err with safs::log_error_code throughout the ChunkTrashManager files, which is good for providing more context to errors. However, ensure that all error logging follows this pattern for consistency.
• Removal of experimental logging functions: The removal of the experimental logging functions from chunk_trash_manager_impl.cc is a significant change. Verify that these functions are no longer needed and that the new logging mechanism adequately covers all use cases.
• Return type consistency: In CmrDisk::unlinkChunk, the return type of ChunkTrashManager::moveToTrash is cast to saunafs_error_code. Ensure that the return types are consistent throughout the codebase to avoid potential issues.

Merge Readiness

The pull request is almost ready for merging. However, there are a few issues that need to be addressed before merging. Specifically, the return type consistency in CmrDisk::unlinkChunk should be verified and corrected if necessary. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

[rolysr]

Please before merging consider fixing the typo on the commit title by: feat: Log error_code related mesasage

[lgsilva3087]

LGTM