chore: Improve main logging #238
Open
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgsilva3087
previously approved these changes
Nov 14, 2024
uristdwarf
force-pushed
the
improve-main-logging
branch
3 times, most recently
from
7139894 to
ec2c53d
Compare
ralcolea
force-pushed
the
improve-main-logging
branch
from
ec2c53d to
80b37dd
Compare
uristdwarf
force-pushed
the
improve-main-logging
branch
5 times, most recently
from
7254626 to
d41b1a9
Compare
uristdwarf
force-pushed
the
improve-main-logging
branch
from
d41b1a9 to
abe8acd
Compare
uristdwarf
force-pushed
the
improve-main-logging
branch
from
abe8acd to
53f20de
Compare
Improve logging to better debug errors and where they occured, also use safs functions. Closes #221 Signed-off-by: Urmas Rist <urmas@leil.io>
Due to (for whatever reason on earth) main logging the output of the pid into stderr, any script expecting only this PID in stderr will break. This fixes it by exiting early after the PID has been acquired Signed-off-by: Urmas Rist <urmas@leil.io>
Signed-off-by: Urmas Rist <urmas@leil.io>
uristdwarf
force-pushed
the
improve-main-logging
branch
from
53f20de to
a7164ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve logging to better debug errors and where they occured, also use safs functions.
Closes #221
[Only merge after #234]