Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Allow to change tests data path #159

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

ictus4u
Copy link
Collaborator

@ictus4u ictus4u commented Aug 1, 2024

When the binary for tests was moved to a different path it could not find the tests bash script.
This commit adds an environment variable to allow the path change in run time.

@ictus4u ictus4u force-pushed the allow-change-test-data-path branch from e790b25 to 8a03a33 Compare August 2, 2024 03:19
@ictus4u ictus4u changed the title fix(tests): Allow to chance tests data path fix(tests): Allow to change tests data path Aug 2, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
@ictus4u ictus4u force-pushed the allow-change-test-data-path branch from 8a03a33 to 33d82ba Compare August 2, 2024 03:28
Copy link
Collaborator

@uristdwarf uristdwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the only thing I would ask is to document this env variable in the README of the tests folder

Copy link
Contributor

@antuan96314 antuan96314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antuan96314 antuan96314 merged commit fffe85e into dev Aug 5, 2024
3 checks passed
@ictus4u ictus4u deleted the allow-change-test-data-path branch August 5, 2024 12:56
uristdwarf pushed a commit that referenced this pull request Aug 13, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
uristdwarf pushed a commit that referenced this pull request Aug 21, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
uristdwarf pushed a commit that referenced this pull request Aug 23, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
uristdwarf added a commit that referenced this pull request Sep 2, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
uristdwarf added a commit that referenced this pull request Sep 2, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
uristdwarf added a commit that referenced this pull request Sep 11, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
uristdwarf added a commit that referenced this pull request Nov 25, 2024
When the binary for tests was moved to a different path it could not
find the tests bash script. This commit adds an environment variable
to allow the path change in run time.

Co-authored-by: Antuan <antuan@leil.io>
Co-authored-by: Crash <crash@leil.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants