-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): Allow to change tests data path #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61f5dc6
to
e790b25
Compare
lgsilva3087
approved these changes
Aug 1, 2024
rolysr
approved these changes
Aug 2, 2024
e790b25
to
8a03a33
Compare
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
8a03a33
to
33d82ba
Compare
uristdwarf
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the only thing I would ask is to document this env variable in the README of the tests folder
antuan96314
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
uristdwarf
pushed a commit
that referenced
this pull request
Aug 13, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
uristdwarf
pushed a commit
that referenced
this pull request
Aug 21, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
uristdwarf
pushed a commit
that referenced
this pull request
Aug 23, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
uristdwarf
added a commit
that referenced
this pull request
Sep 2, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
uristdwarf
added a commit
that referenced
this pull request
Sep 2, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
uristdwarf
added a commit
that referenced
this pull request
Sep 11, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
uristdwarf
added a commit
that referenced
this pull request
Nov 25, 2024
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <antuan@leil.io> Co-authored-by: Crash <crash@leil.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the binary for tests was moved to a different path it could not find the tests bash script.
This commit adds an environment variable to allow the path change in run time.