sfsmount does not work with default in fstab#853
Conversation
through trial and error I found `rw` works
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for /etc/fstab entries to use the rw option instead of default. Feedback suggests that a more robust solution would be to update the option parsing logic in the source code to handle standard default and defaults keywords, rather than just updating the example in the documentation.
| You can define your `/etc/fstab` SaunaFS share like this: | ||
|
|
||
| saunafs-master:/ /mnt/saunafs safs default 0 0 | ||
| saunafs-master:/ /mnt/saunafs safs rw 0 0 |
There was a problem hiding this comment.
While changing the example to rw avoids the error, the root cause is that sfsmount does not handle the standard defaults (or default) option commonly used in /etc/fstab. This causes the FUSE library to reject the mount command with an 'unknown option' error. A more robust fix would be to update the option parsing logic in src/mount/fuse/mount_config.cc to recognize and ignore these keywords. You can add FUSE_OPT_KEY("default", FUSE_OPT_KEY_DISCARD), and FUSE_OPT_KEY("defaults", FUSE_OPT_KEY_DISCARD), to the gSfsOptsStage2 array. This would allow users to follow standard fstab conventions, where defaults (plural) is the conventional keyword.
through trial and error I found
rwworks. withdefaultI got: