Skip to content

sfsmount does not work with default in fstab#853

Open
butonic wants to merge 1 commit into
leil-io:devfrom
butonic:patch-2
Open

sfsmount does not work with default in fstab#853
butonic wants to merge 1 commit into
leil-io:devfrom
butonic:patch-2

Conversation

@butonic

@butonic butonic commented May 5, 2026

Copy link
Copy Markdown
Contributor

through trial and error I found rw works. with default I got:

butonic@khal:/mnt$ sudo mount leilfs/
sfsmaster accepted connection with parameters: read-write ; root mapped to root:root
05/05/26 16:19:41.945 [info] [85447:85459] : Received IO limits configuration update from master
[2026-05-05 16:19:41.945] [info] Received IO limits configuration update from master
fuse: unknown option(s): `-o default'
error in fuse_session_new
05/05/26 16:19:43.946 [warning] [85447:85459] : master: connection lost
[2026-05-05 16:19:43.946] [warning] master: connection lost
05/05/26 16:19:43.946 [warning] [85447:85459] : master: disconnected
[2026-05-05 16:19:43.946] [warning] master: disconnected

through trial and error I found `rw` works

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for /etc/fstab entries to use the rw option instead of default. Feedback suggests that a more robust solution would be to update the option parsing logic in the source code to handle standard default and defaults keywords, rather than just updating the example in the documentation.

Comment thread doc/sfsmount.1.adoc
You can define your `/etc/fstab` SaunaFS share like this:

saunafs-master:/ /mnt/saunafs safs default 0 0
saunafs-master:/ /mnt/saunafs safs rw 0 0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While changing the example to rw avoids the error, the root cause is that sfsmount does not handle the standard defaults (or default) option commonly used in /etc/fstab. This causes the FUSE library to reject the mount command with an 'unknown option' error. A more robust fix would be to update the option parsing logic in src/mount/fuse/mount_config.cc to recognize and ignore these keywords. You can add FUSE_OPT_KEY("default", FUSE_OPT_KEY_DISCARD), and FUSE_OPT_KEY("defaults", FUSE_OPT_KEY_DISCARD), to the gSfsOptsStage2 array. This would allow users to follow standard fstab conventions, where defaults (plural) is the conventional keyword.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant