GA bot handles some signatures incorrectly (fix included)

[owcz]

Didn't hear back on talk page, so reposting (all details are below, with a proposed fix by Chris G—just needs to be tested)

https://en.wikipedia.org/wiki/User_talk:Legoktm/March_2017#GA_bot_doesn.27t_count_some_signatures

I recently figured out how to reproduce a long-standing issue with the GA bot in which some editors (including myself) do not receive bot notifs about the review or review counts next to their signatures on WP:GAN. The bot needs to see a "User:" link in the nominator's signature. Currently, signatures with only "User_talk:" links will not receive notifs/counts. Edits like this appear to fix it. Would you be able to tweak the signature detection in the code so that it works with all signatures? (I think it's potentially line 259.) If you're unavailable, is there someone else who can help? czar 20:20, 2 March 2017 (UTC)

It's been years since I've looked at that code. But from what you're describing I think this should do the trick:

<?php
// Line 255
public function setNominator ( $nominator ) {
	$nominator = trim($nominator);
	if (!empty($nominator)) {
		$this->nominator = $nominator;
		preg_match("/\[\[User([ _]talk)?:(.+?)\|.+?\]\]/",$nominator,$m);
		if (!empty($m[2]))
			$this->nominator_plain = trim(ucfirst(str_replace('_',' ',$m[2])));
	}
}

--Chris 13:25, 3 March 2017 (UTC)

[Swpb2]

This match should also be case insensitive; "user talk" should work as well as "User talk".