-
Notifications
You must be signed in to change notification settings - Fork 11
Rename to raw_image_pipeline #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JonasFrey96 do you have any further comments on this? Otherwise I'll merge and will propagate the other changes to |
I will review this in the morning. Sorry for the delay. |
Everything looks great and builds nicely. Minor issue: Can create a leggedrobotics forge of your pybind11_catkin.git such that everything stays under the same domain. |
Awesome, thanks. I'll add more information on the different modules and how to do color calibration, @nivedchebrolu wrote a related issue #3 Regarding pybind, I'll check if there are any issues with the latest changes https://github.com/wxmerkt/pybind11_catkin |
Ok, some important changes:
There are 3 namespaces now:
Additionally, we can now indicate if the image is mono or color. If it's mono, it will publish to a different namespace instead mono_rect which is useful for visual odometry stuff.
|
The Readme should have an image or video showing the different stages of processing. Could you add one? |
@mauricefallon Yes, good call. I'll update the figure I used to have (see below) to reflect both the new updates to the pipeline as well as what's being published now |
@mmattamala There's also a typo in the |
e16f06a
to
3dbd9f6
Compare
Ok, merging this! New changes will be introduced as new PRs |
only apply the cuda pipeline when there are subscribers
FYI: @YifuTao @rowanborder @nivedchebrolu @mauricefallon @ckassab @JonasFrey96 @plibera
This introduces important changes, as all the names that were
image_proc_cuda*
are changed toraw_image_pipeline*
as it reflects better the fact that the code works independently of the hardware (CPU or GPU)I also propose to change the repo name to
raw_image_pipeline
as it is Alphasense-independent and could be useful for other devices.If we are all fine with this: