-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAr AC classifier: changes to larveto.py
#574
Conversation
- split time term from amplitude term & added correct signs (minus for time term, plus for amplitude) - made time pdf a true normalized pdf by adding (1-bkg_prob) factor in front of double exponential - changed naming sing2trip_ratio -> sing2tot_ratio - changed amplitude pdf to log pdf to mitigate numerical problems - draft for amplitude log pdf function at the end (commented out)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 21.34% 21.38% +0.03%
==========================================
Files 42 42
Lines 7907 7907
==========================================
+ Hits 1688 1691 +3
+ Misses 6219 6216 -3 ☔ View full report in Codecov by Sentry. |
(1-bkg_prob)
factor in front of double exponentialsing2trip_ratio
->sing2tot_ratio