Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAr AC classifier: changes to larveto.py #574

Merged
merged 10 commits into from
May 8, 2024

Conversation

rosannadeckert
Copy link
Contributor

@rosannadeckert rosannadeckert commented Apr 23, 2024

  • split time term from amplitude term & added correct signs (minus for time term, plus for amplitude)
  • made time pdf a true normalized pdf by adding (1-bkg_prob) factor in front of double exponential
  • changed naming sing2trip_ratio -> sing2tot_ratio
  • changed amplitude pdf to log pdf to mitigate numerical problems
  • amplitude log pdf function uses user-provided pdf (and arg in the main function)
  • review numerical stability
  • allow for changing the probability of random pulses (and arg in the main function)
  • filter pulses with a noise threshold suitable for the classifier (i.e. no afterpulses)

@gipert gipert added the evt build events from hit data label Apr 23, 2024
@gipert gipert marked this pull request as draft April 23, 2024 15:30
- split time term from amplitude term & added correct signs (minus for time term, plus for amplitude)
- made time pdf a true normalized pdf by adding (1-bkg_prob) factor in front of double exponential
- changed naming sing2trip_ratio -> sing2tot_ratio
- changed amplitude pdf to log pdf to mitigate numerical problems
- draft for amplitude log pdf function at the end (commented out)
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.38%. Comparing base (e7b7b36) to head (6a4ce89).
Report is 223 commits behind head on main.

❗ Current head 6a4ce89 differs from pull request most recent head be05b5f. Consider uploading reports for the commit be05b5f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   21.34%   21.38%   +0.03%     
==========================================
  Files          42       42              
  Lines        7907     7907              
==========================================
+ Hits         1688     1691       +3     
+ Misses       6219     6216       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosannadeckert rosannadeckert marked this pull request as ready for review May 7, 2024 14:39
@gipert gipert merged commit bb7f64d into legend-exp:main May 8, 2024
12 checks passed
@rosannadeckert rosannadeckert deleted the my-dev branch May 9, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evt build events from hit data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants