Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for pargen load_data to eval all fields in hit dict, specify dtype when init lh5 objects in evt and support subtables in skm #554

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

ggmarshall
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a0a4400) 22.75% compared to head (0b569e9) 22.79%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/pygama/pargen/utils.py 0.00% 8 Missing ⚠️
src/pygama/math/histogram.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   22.75%   22.79%   +0.04%     
==========================================
  Files          42       42              
  Lines        8117     8119       +2     
==========================================
+ Hits         1847     1851       +4     
+ Misses       6270     6268       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert added bug Something isn't working pargen Generation of analysis parameters (calibrations etc.) evt build events from hit data labels Feb 2, 2024
@gipert gipert merged commit 3399d20 into legend-exp:main Feb 2, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working evt build events from hit data pargen Generation of analysis parameters (calibrations etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants