Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pandas future deprecations #550

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

patgo25
Copy link
Contributor

@patgo25 patgo25 commented Jan 23, 2024

  1. Pandas will depend on pyarrow
  2. Pandas to_numeric function deprecates error parameter --> filedb uses it with the ignore value (just returns the input value. --> catching now ValueErrors and continue

@gipert gipert added the dependencies Pull requests that update a dependency file label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (263052f) 17.85% compared to head (bc183a5) 17.87%.

Files Patch % Lines
src/pygama/flow/file_db.py 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   17.85%   17.87%   +0.02%     
==========================================
  Files          34       34              
  Lines        7523     7529       +6     
==========================================
+ Hits         1343     1346       +3     
- Misses       6180     6183       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert merged commit 7eacdd8 into legend-exp:main Jan 23, 2024
11 checks passed
@patgo25 patgo25 deleted the fix_pandas_future_warnings branch January 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants