Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build_hit() to support the latest Table.eval() #543

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

gipert
Copy link
Member

@gipert gipert commented Jan 10, 2024

  • We can now process VectorOfVectors too!
  • Added lgdo_attrs key in the build_hit config dictionary for setting LGDO attributes like units.

See legend-exp/legend-pydataobj#53.

@gipert gipert added the hit Processing DSP output (calibration, classifiers...) label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0adfdc2) 18.25% compared to head (cc3b426) 18.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   18.25%   18.30%   +0.05%     
==========================================
  Files          33       33              
  Lines        7167     7173       +6     
==========================================
+ Hits         1308     1313       +5     
- Misses       5859     5860       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert marked this pull request as ready for review January 11, 2024 10:47
@gipert gipert merged commit dc72406 into main Jan 11, 2024
11 checks passed
@gipert gipert deleted the build-hit branch January 11, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hit Processing DSP output (calibration, classifiers...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant