Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated np.float_ calls #80

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

SamuelBorden
Copy link
Contributor

get_multi_local_extrema was calling np.float_ which is deprecated in numpy 2.0 and is causing BuildTheDocs to fail in other repos. I've replaced these calls with np.float64

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.51%. Comparing base (641e1cb) to head (a9dd693).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files          48       48           
  Lines        3234     3234           
=======================================
  Hits         1957     1957           
  Misses       1277     1277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert merged commit a9e1e9f into legend-exp:main Aug 12, 2024
13 checks passed
@gipert gipert mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants