Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of coordinate variables #63

Merged
merged 10 commits into from
Mar 24, 2024
Merged

Conversation

iguinn
Copy link
Collaborator

@iguinn iguinn commented Mar 24, 2024

  • Handle binary operators on coordinate variables correctly. Before, result of binary operator just inherited the first variables coordinate grid and status as a coordinate variable. Now, it:
    • If both variables are coordinates, treats the result as not a coordinate. This is because the most likely use case for this is for differences between time points, and these should not be coordinates
    • If one variable is a coordinate, inherit the values from that variable. This is because the most likely result for this is applying an offset to a coordinate (e.g. 5*us from tp_0)
    • If neither variable is a coordinate, result is not a coordinate
    • If these cases are not suitable, user will have to specify it
  • Fixed failure to convert units correctly for coordinates when writing output buffers for VectorOfVectors and ArrayOfEqualSizeArrays
  • Made single-value subscripts work as expected
  • Fixed error raised when adding constant values
  • Fixed bug that prevented all values in VoV and AoESA to be drawn by waveform browser
  • Constant values are by default not treated as coordinates
  • Other small bug fixes and code cleanups

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 61.87%. Comparing base (758c7c9) to head (74dfe76).
Report is 16 commits behind head on main.

Files Patch % Lines
src/dspeed/processing_chain.py 47.05% 27 Missing ⚠️
src/dspeed/vis/waveform_browser.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   61.34%   61.87%   +0.53%     
==========================================
  Files          46       46              
  Lines        3073     3111      +38     
==========================================
+ Hits         1885     1925      +40     
+ Misses       1188     1186       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iguinn iguinn merged commit 53e478f into legend-exp:main Mar 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant