Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in handling of coordinates #22

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Fixed bug in handling of coordinates #22

merged 5 commits into from
Nov 14, 2023

Conversation

iguinn
Copy link
Collaborator

@iguinn iguinn commented Nov 14, 2023

See #18

  • Added unit test to help catch cases like this
  • Added fix to bug in handling of units
  • Added fix to addition of quantities to coordinates (e.g. 5*us + t0) not working if quantity comes first
  • Added fix to slices adding 0 unnecessarily

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e3dacf2) 61.56% compared to head (c31239f) 61.69%.

Files Patch % Lines
src/dspeed/processing_chain.py 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   61.56%   61.69%   +0.13%     
==========================================
  Files          40       40              
  Lines        2677     2684       +7     
==========================================
+ Hits         1648     1656       +8     
+ Misses       1029     1028       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iguinn iguinn merged commit c11ee13 into legend-exp:main Nov 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant