Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepCollapseChildren prop for allowing deeply collapsed children #131

Merged
merged 3 commits into from
Aug 28, 2021
Merged

Add deepCollapseChildren prop for allowing deeply collapsed children #131

merged 3 commits into from
Aug 28, 2021

Commits on Aug 17, 2021

  1. Collapse children greater than or equal to depth

    When a user specifies a depth to be collapsed, the intention is to make the JSON tidy so it is easy to visually parse.
    
    Currently the `deep` prop only collapses at the specific level passed, and when a user opens that depth, all children are fully open.
    
    I think this should collapse all children beyond the depth level, so that when the items are opened up the children are collapsed.
    
    That said, for backwards compatibility I've implemented this as a new prop, defaulting to false, so that anyone upgrading won't see a change in behaviour.
    fredrivett authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    4466109 View commit details
    Browse the repository at this point in the history
  2. Update README to include deepCollapseChildren

    Let the user know about the new prop for collapsing all children at the level below the `deep` prop passed.
    fredrivett authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6ae805f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Add deepCollapseChildren to basic demo

    This is a new option provided for collapsing children inside those
    collapsed by default, so is exposed here
    fredrivett committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    aa79ca5 View commit details
    Browse the repository at this point in the history