Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tinyxml2 namespaces' ending comment #992

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

ssmolov
Copy link
Contributor

@ssmolov ssmolov commented Aug 12, 2024

Several code analysers, like clang-tidy, report warnings on ending comment for tinyxml2 namespace. Here is a clang-tidy 12.0.0 log fragment:

../tinyxml2/tinyxml2.h:2377:2: warning: namespace 'tinyxml2' ends with an unrecognized comment [llvm-namespace-comment]
}       // tinyxml2
 ^~~~~~~~~~~~~~~~~~
  // namespace tinyxml2
../tinyxml2/tinyxml2.h:114:11: note: namespace 'tinyxml2' starts here
namespace tinyxml2
          ^

This pull request is aimed to fix the issue.

Signed-off-by: Sergey Smolov <smolov@ispras.ru>
Signed-off-by: Sergey Smolov <smolov@ispras.ru>
@leethomason leethomason merged commit 2ac336a into leethomason:master Sep 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants