This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
forked from misza222/heroku-buildpack-casperjs
-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
merge stomita's update (phantomjs updated to 1.9.2)
Changes to be committed: modified: README.md modified: bin/casperjs.sh modified: bin/compile modified: bin/release
- Loading branch information
Showing
4 changed files
with
33 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
687a395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this commit broke
casperjs
for us on Heroku:/usr/bin/env: casperjs: No such file or directory
Rolling back this commit did the trick. Maybe a path issue? I wonder if any one else had similar issues.
687a395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks for the info.
Haven't deployed this commit on Heroku.
687a395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to run
heroku config:set PATH="${PATH}:/app/vendor/phantomjs/bin:/app/vendor/casperjs/bin"
heroku config:set LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/app/vendor/phantomjs/lib"
and then it worked.
687a395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the report, I wonder why the modification in
bin/release
is not working.687a395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented out the part for using
profile.d/casperjs.sh
in the update to 1.9.2.I've updated again to add it back again.
Thanks for the report.