Skip to content

Commit

Permalink
Add basic support for multiple HAVING clauses. All clauses will be AN…
Browse files Browse the repository at this point in the history
…Ded together.
  • Loading branch information
kiwih committed Jul 22, 2015
1 parent 82d726b commit a9cdf1d
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 21 deletions.
18 changes: 16 additions & 2 deletions scope_private.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,24 @@ func (scope *Scope) groupSql() string {
}

func (scope *Scope) havingSql() string {
if scope.Search.havingCondition == nil {
if scope.Search.havingConditions == nil {
return ""
}
return " HAVING " + scope.buildWhereCondition(scope.Search.havingCondition)

var andConditions []string

for _, clause := range scope.Search.havingConditions {
if sql := scope.buildWhereCondition(clause); sql != "" {
andConditions = append(andConditions, sql)
}
}

combinedSql := strings.Join(andConditions, " AND ")
if len(combinedSql) == 0 {
return ""
}

return " HAVING " + combinedSql
}

func (scope *Scope) joinsSql() string {
Expand Down
38 changes: 19 additions & 19 deletions search.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,24 @@ package gorm
import "fmt"

type search struct {
db *DB
whereConditions []map[string]interface{}
orConditions []map[string]interface{}
notConditions []map[string]interface{}
havingCondition map[string]interface{}
initAttrs []interface{}
assignAttrs []interface{}
selects map[string]interface{}
omits []string
orders []string
joins string
preload []searchPreload
offset string
limit string
group string
tableName string
raw bool
Unscoped bool
db *DB
whereConditions []map[string]interface{}
orConditions []map[string]interface{}
notConditions []map[string]interface{}
havingConditions []map[string]interface{}
initAttrs []interface{}
assignAttrs []interface{}
selects map[string]interface{}
omits []string
orders []string
joins string
preload []searchPreload
offset string
limit string
group string
tableName string
raw bool
Unscoped bool
}

type searchPreload struct {
Expand Down Expand Up @@ -93,7 +93,7 @@ func (s *search) Group(query string) *search {
}

func (s *search) Having(query string, values ...interface{}) *search {
s.havingCondition = map[string]interface{}{"query": query, "args": values}
s.havingConditions = append(s.havingConditions, map[string]interface{}{"query": query, "args": values})
return s
}

Expand Down

0 comments on commit a9cdf1d

Please sign in to comment.