Open
Conversation
|
It is better not to implement this if it causes performance loss with active tiling, which is naturally used in all low-end systems with little VRAM. |
Contributor
Author
Only when both tiling and circular are enabled. If either is disabled the performance is basically unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vae tiling was not working nicely with
--circularflags. This PR aims at improving that by making the tiling circular instead of the VAE itself.Example with
sd-cli.exe --diffusion-model ..\ComfyUI\models\unet\Flux\klein\flux-2-klein-9b-Q6_K.gguf --vae ..\ComfyUI\models\vae\flux\Flux.2-VAE.safetensors --llm ..\ComfyUI\models\clip\llms\Qwen3-8b.Q4_K_XL.gguf --cfg-scale 1.0 -p '360 HDRI panorama image, capturing a wide, 360-degree view of living room. Intimate atmosphere<lora:Klein_9B - HDRI_360_panoramic:1.3>' --scheduler smoothstep --steps 8 -W 1024 -H 512 --rng cpu --lora-model-dir ..\ComfyUI\models\loras\flux\klein9\ --circularx --vae-tiling --vae-tile-size 16(lora: https://civitai.green/models/2413837/hdri-flux2klein-9b)
Example with
sd-cli.exe --diffusion-model ..\ComfyUI\models\unet\Flux\klein\flux-2-klein-9b-Q6_K.gguf --vae ..\ComfyUI\models\vae\flux\Flux.2-VAE.safetensors --llm ..\ComfyUI\models\clip\llms\Qwen3-8b.Q4_K_XL.gguf --cfg-scale 1.0-p 'Aerial view of a very busy city' --preview proj --steps 8 -W 512 -H 512 --rng cpu --circular --scheduler smoothstep - -vae-tiling-vae-tile-size 16