Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually triggered release leads to CI failure b/c Copy and pack Cuda runtime step is run for non-CUDA builds #355

Open
jparismorgan opened this issue Aug 20, 2024 · 0 comments

Comments

@jparismorgan
Copy link

What

I manually triggered a release in the GitHub CI (on a forked version of the repo): https://github.com/jparismorgan/stable-diffusion.cpp/actions/runs/10475861930/job/29013490348

But it failed with:

Run echo "Cuda install location: "
Cuda install location: 

-------------------------------------------------------------------------------
   ROBOCOPY     ::     Robust File Copy for Windows                              
-------------------------------------------------------------------------------

  Started : Tuesday, August 20, 2024 4:56:54 PM
   Source : D:\bin\
     Dest : D:\a\stable-diffusion.cpp\stable-diffusion.cpp\build\bin\cudart\

    Files : cudart64_*.dll
	    cublas64_*.dll
	    cublasLt64_*.dll
	    
  Options : /DCOPY:DA /COPY:DAT /R:[10](https://github.com/jparismorgan/stable-diffusion.cpp/actions/runs/10475861930/job/29013490348#step:10:11)00000 /W:30 

------------------------------------------------------------------------------

2024/08/20 16:56:54 ERROR 2 (0x00000002) Accessing Source Directory D:\bin\
The system cannot find the file specified.
Screenshot 2024-08-20 at 7 15 02 PM

Fix

The issue seems to be because Copy and pack Cuda runtime was run for "avx2", even though Install cuda-toolkit was not.

This is because we have:

- name: Copy and pack Cuda runtime
      id: pack_cuda_runtime
      if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' && matrix.build == 'cuda12' ) || github.event.inputs.create_release == 'true' }}

But I think it probably is supposed to be:

- name: Copy and pack Cuda runtime
        id: pack_cuda_runtime
        if: ${{ ( ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' ) && matrix.build == 'cuda12' }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant