Manually triggered release leads to CI failure b/c `Copy and pack Cuda runtime` step is run for non-CUDA builds

[jparismorgan]

What

I manually triggered a release in the GitHub CI (on a forked version of the repo): https://github.com/jparismorgan/stable-diffusion.cpp/actions/runs/10475861930/job/29013490348

But it failed with:

Run echo "Cuda install location: "
Cuda install location: 

-------------------------------------------------------------------------------
   ROBOCOPY     ::     Robust File Copy for Windows                              
-------------------------------------------------------------------------------

  Started : Tuesday, August 20, 2024 4:56:54 PM
   Source : D:\bin\
     Dest : D:\a\stable-diffusion.cpp\stable-diffusion.cpp\build\bin\cudart\

    Files : cudart64_*.dll
	    cublas64_*.dll
	    cublasLt64_*.dll
	    
  Options : /DCOPY:DA /COPY:DAT /R:[10](https://github.com/jparismorgan/stable-diffusion.cpp/actions/runs/10475861930/job/29013490348#step:10:11)00000 /W:30 

------------------------------------------------------------------------------

2024/08/20 16:56:54 ERROR 2 (0x00000002) Accessing Source Directory D:\bin\
The system cannot find the file specified.

Fix

The issue seems to be because Copy and pack Cuda runtime was run for "avx2", even though Install cuda-toolkit was not.

This is because we have:

- name: Copy and pack Cuda runtime
      id: pack_cuda_runtime
      if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' && matrix.build == 'cuda12' ) || github.event.inputs.create_release == 'true' }}

But I think it probably is supposed to be:

- name: Copy and pack Cuda runtime
        id: pack_cuda_runtime
        if: ${{ ( ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' ) && matrix.build == 'cuda12' }}