Repository navigation
use-family 0.9.1: right install hints on Intel Macs, and check image-use - #32
Merged
Merged
Conversation
On an Intel Mac the session-start check sent the agent to two installers that
stop with an error: wechat-use's ("Apple Silicon only") and discord-use's (no
Intel binary). It also never checked image-use, which has no install.sh.
- doctor.sh: name wechat-use only on Apple Silicon; for discord-use on Intel,
give the cargo build-from-source command; check image-use and give its
clone-and-link command.
- install-use-family.sh: same wechat-use and discord-use handling.
- tests/doctor.test.sh (new, in CI) and install-use-family.test.sh: run as
both arm64 and x86_64 with a fake uname.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Found while installing the whole family on an Intel Mac (i9, macOS Tahoe):
doctor.sh) tells the agent to run wechat-use's installer, which stops with "Apple Silicon only".install.sh(that URL is a 404), so a missing image-use CLI went unreported.Changes
doctor.sh: suggest wechat-use only on Apple Silicon. On Intel, give thecargo install --git … --root ~/.localcommand for discord-use. Check image-use and give the clone-and-link command (no sudo, into~/.local/bin).install-use-family.sh: same wechat-use and discord-use handling (the image-use hint there already existed).tests/doctor.test.sh(added to CI).install-use-family.test.shnow runs as both arm64 and x86_64 with a fakeuname. The new doctor test fails against the old script.Not in this PR (other repos)
install.shusesdirname "$0"as the checkout. If you download the script and run it as a file, it links the skill to wherever the file is. If you pipe it (curl | sh),$0issh. Either way it doesn't clone the repo like memory-use's installer does.install.sh, unlike the rest of the family.🤖 Generated with Claude Code