Merge pull request iluwatar#793 from andrievsky/master

Fix redundant list alloc in LotteryNumbers
leegojames · Oct 13, 2018 · 8433c7b · 8433c7b
2 parents ee74fec + 1d12d94
commit 8433c7b
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryNumbers.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/domain/LotteryNumbers.java
@@ -22,13 +22,12 @@
  */
 package com.iluwatar.hexagonal.domain;
 
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashSet;
-import java.util.List;
 import java.util.PrimitiveIterator;
 import java.util.Random;
 import java.util.Set;
+import java.util.Iterator;
 
 /**
  *
@@ -85,11 +84,10 @@ public Set<Integer> getNumbers() {
    * @return numbers as comma separated string
    */
   public String getNumbersAsString() {
-    List<Integer> list = new ArrayList<>();
-    list.addAll(numbers);
     StringBuilder builder = new StringBuilder();
+    Iterator<Integer> iterator = numbers.iterator();
     for (int i = 0; i < NUM_NUMBERS; i++) {
-      builder.append(list.get(i));
+      builder.append(iterator.next());
       if (i < NUM_NUMBERS - 1) {
         builder.append(",");
       }