added scrollTo #831
Merged
added scrollTo #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge It ! |
|
Please merge. 😃 |
|
Merge it!! |
|
this.refs.swiper.scrollBy(index - this.state.index) works around this for me btw. |
|
👍 Can we have this? the above solution works but scrollTo would be very nice. |
|
@leecade please merge this. ScrollTo is very important compared to ScrollBy |
|
I don't have write access. sorry. Ask @leecade 💯 |
offcarlospetit
approved these changes
Jun 18, 2019
This was referenced Jun 26, 2019
|
Shouldn't this also be added to the typescript definition like #931? |
|
how is this meant to be used? I dont see any scrollTo property in latest nightly version |
|
Doesn't seems to be working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Is it a new feature ?
Describe what you've done:
scroll to specific slider
How to test it ?
call scrollTo using a button, and swiper reference, using index as parameter (eg, using a toolbar on top)