Fix inconsistent index when number of pages changes #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 16, 2017 08:58
|
This is import fix - without it component is not usable for presenting dynamic data. Please consider the opportunity to merge it to master Edit: After some experiments, this PR don't fully resolve my issues - if I use 3 slides when updated children and set 1 and then go back to 3 - index calculating is wrong. But this PR #655 resolves this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Yes, it should fix #637, #635, #632, #617, and maybe others.
Describe what you've done:
in the
initStatefunction, if the number of items changes or index should be changed, it was setting it to the lower of either: the current index, or the total childen minus 1. However, the number of children was already updated, meaning that the index should be equal to the current number of children, so I just removed the minus 1.How to test it ?
Add/remove pages, see if index remains consistent.