Update examples #500
Merged
Update examples #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 7, 2017 18:03
Collaborator
Author
|
@mrdezzods Can you check it ? |
Collaborator
|
@arribbar I will check it once I get back to my computer. Thanks |
Collaborator
|
Code looks ok. You can update the gifs as well (if there is UI change in the examples) |
Collaborator
Author
|
The UI does not change except for Swiper and SwiperNumber. But it is because renderTitle do not work. I would let it like that and add one issue. I removed PhotoView example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
It should fix #494 and fix #495
Done
yarncommand