Skip to content

Fix exporter compilation error when Unity is not 2022.3. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

timbotimbo
Copy link
Collaborator

Description

A fix for a very minor issue.
The exporter script is supposed to show an error dialog on Unity versions that aren't 2022.3.

However the code within #if !UNITY_2022_3 doesn't even compile, it likely got left behind in a refactor because the 2022.3 compiler doesn't validate it.

This PR simply makes it compile again.

#if !UNITY_2022_3
-        ShowErrorMessage("This plugin only supports Unity 2022.3 LTS (Long Term Support).");
-        return ProjectExportCheckerResult.Failure();
+        ProjectExportHelpers.ShowErrorMessage("This plugin only supports Unity 2022.3 LTS (Long Term Support).");
+        return false;
#endif

@jamesncl jamesncl merged commit baea14e into learntoflutter:main Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants