Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add notification_created event to register on logs #32

Merged
merged 4 commits into from
Oct 14, 2021
Merged

add notification_created event to register on logs #32

merged 4 commits into from
Oct 14, 2021

Conversation

danielneis
Copy link
Contributor

Hello,
I've added this basic log just to check if you like the idea.
I'll add logs to update and delete too and more info on the log object (during this week).
Best,
Daniel

@danielneis
Copy link
Contributor Author

Hi,
I've added log events for updating and deleting notifications.
Hope you like it.
Best,
Daniel

@danielneis danielneis force-pushed the add-log-notification-created branch from 78eb597 to be0bb0f Compare September 23, 2021 13:09
@danielneis danielneis force-pushed the add-log-notification-created branch from be0bb0f to 6e95497 Compare September 23, 2021 13:13
@zpottie
Copy link
Contributor

zpottie commented Sep 23, 2021

Really like this too @danielneis - thanks! I'll give a proper look on my computer. 👌

@danielneis
Copy link
Contributor Author

I've added information about old and new values when updating and about the old values when deleting.
Hope you like!
Screenshot from 2021-09-29 14-56-39
Screenshot from 2021-09-29 14-56-32
Best,
Daniel

zpottie
zpottie suggested changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@zpottie zpottie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is for all crud logs' strings.

classes/event/notification_updated.php Show resolved Hide resolved
@danielneis
Copy link
Contributor Author

Hi,
I would like it very much to see those strings translated, but all the log event descriptions are not translatable, they are all hardcoded.
https://tracker.moodle.org/browse/MDL-60565

@zpottie
Copy link
Contributor

zpottie commented Oct 14, 2021

Hi, I would like it very much to see those strings translated, but all the log event descriptions are not translatable, they are all hardcoded. https://tracker.moodle.org/browse/MDL-60565

Crazy, didn't even know that - all good then! Thanks for this! 👍

@zpottie zpottie merged commit b253b07 into learningworks:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpottie zpottie zpottie approved these changes

Assignees
No one assigned
Labels
contrib enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielneis @zpottie