(#43) Complete new-spec lesson-metadata migration in resource pipeline#64
Draft
alexsdev91 wants to merge 1 commit into
Draft
(#43) Complete new-spec lesson-metadata migration in resource pipeline#64alexsdev91 wants to merge 1 commit into
alexsdev91 wants to merge 1 commit into
Conversation
alexsdev91
force-pushed
the
43-fix-lesson-metadata-specs
branch
from
e5be30e to
e1f8c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lesson imports under the new metadata spec (#43) were crashing with
undefined method 'children' for nilbecause the resource-building pipeline still consumed the legacyunit/section/lessonkeys. Also adds the missing[material: ID]inline tag and accepts the spec's bracketed[lms-materials]table header.Changes
Lt::Lcms::Metadata::Context: readunit-id,section-number,lesson-number; raise on unsupported subject; guardnilparent inset_lesson_position; consistent all-string keys.UnitResourceUpsertService/SectionResourceUpsertService: passnew-spec keys to
Context.Document#clean_curriculum_metadata: drop dead legacy lessonnormalization.
DocTemplate::Tables::LmsMaterials: match bracketed header(
[lms-materials]) via substring, consistent withlesson-prep/lesson-metadata.DocTemplate::Tags::MaterialTag: resolves[material: ID]to alink; renders a red badge in place when the identifier is unknown.