Skip to content

Conversation

@LightCreator1007
Copy link

Summary

  • Changed the link from "learn about collections" to "learn more about collections".
  • Aligned it after the description text.
  • Still aligned to the right if collections are available.
  • added vertical spacing between button and text.
image

References

Slack Conversation Link:
https://learningequality.slack.com/archives/C03S2EN192A/p1761950793197879

@MisRob
Copy link
Member

MisRob commented Nov 11, 2025

Thanks @LightCreator1007, we will assign a reviewer within next two weeks.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LightCreator1007,

User-experience wise, changes look as expected. Thanks for contributing.

As for code, can you simplify? One area to look into would be <KModal v-if="infoDialog">. Multiple same instances are not needed. You can also revisit the whole file and see if you find more places that can be optimized.

@MisRob MisRob self-assigned this Nov 17, 2025
@LightCreator1007
Copy link
Author

Since I had to merge unstable into my branch and also made an additional commit for the requested changes, I now need to either push both commits as they are or perform a rebase and squash before pushing.

Could you please let me know which approach would be preferable?

@MisRob
Copy link
Member

MisRob commented Nov 18, 2025

Hi @LightCreator1007, feel free to push. But since the diff is small and I haven't yet reviewed in detail, if you find yourself in the need of rebase, that'd be fine too. Thanks for asking.

@LightCreator1007 LightCreator1007 force-pushed the fix-link-orientation-collections branch from 38ded67 to 5f4b68f Compare November 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants