-
Notifications
You must be signed in to change notification settings - Fork 254
[Remove Vuetify from Studio] Channel details in Channels - content #5540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Channel details in Channels - content #5540
Conversation
61e0727 to
5c41386
Compare
|
Hi @vtushar06, thank you. As for the structure of components, and very high-level, looks as expected 👍 Before we dive into full review though, let's revisit approach to testing. This will help a reviewer too - they will be able to recognize whether the logic behaves as expected for channels with/without all sorts of data. Also, the guidance I left is quite general. I know you have more PRs open - would you please check if there are some similar patterns to be addressed there as well? |
contentcuration/contentcuration/frontend/shared/views/__tests__/StudioChip.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/__tests__/StudioDetailsPanel.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/__tests__/StudioDetailsPanel.spec.js
Show resolved
Hide resolved
|
Hii @MisRob, |
|
One more thing when I tested this in 'rtl' I can see that notranslate class doesn't follow that on official website and same on localhost, what should I do to that?? |
|
Hi @vtushar06, We will assign reviewer here week or two later, some time after we've merged few other PRs, one of them yours, that will be good to have in place before we check these changes. Meanwhile you can revisit: (1) The use of stubs and possible simplification of the test suite setup according to notes I left today on your other PRs, if relevant. (2) As for your note:
I don't yet see this in |
I don't quite understand the question - would you post a screenshot, or rephrase? |
|
Hi @vtushar06, I wanted to mention that I've just merged another PR that introduces I think it'd be easiest if you rebased this PR on top of the latest |
…n from unstable The contributor's StudioChip implementation is identical to ours. We'll use their version from unstable and focus on test refactoring following Issue learningequality#5536 patterns (data-present vs data-absent scenarios). Following maintainer guidance from PR learningequality#5540 review.
f5d6f31 to
5600ff2
Compare
… add cases for various data states and edge cases
…formatting and style consistency
ba4add6 to
ff8e9e0
Compare
|
Hi @MisRob, I've completed all the requested changes - tests now follow VTL principles with data-present/absent scenarios, and I'm using the contributor's StudioChip from unstable. About RTL/notranslate: The notranslate class is for excluding user content from translation services, not for text direction. The dir="auto" attribute handles RTL direction. Is this the expected behavior? and all 41 tests passing. Now it is ready for review . |
Summary
Migrates ChannelDetailsModal from Vuetify to Kolibri Design System (KDS).
Components
Key Changes
Testing
Screen-Recording:
Channel.details.modal.mp4
…
References
fixes : #5530
…
Reviewer guidance
…