Skip to content

Conversation

@vtushar06
Copy link
Contributor

@vtushar06 vtushar06 commented Nov 7, 2025

Summary

Migrates ChannelDetailsModal from Vuetify to Kolibri Design System (KDS).

Components

  • StudioDetailsRow.vue - CSS Grid layout replacing VLayout/VFlex
  • StudioDetailsPanel.vue - Complete KDS migration with KImg, KTooltip, semantic HTML
  • Uses existing StudioChip from unstable (contributor's implementation)

Key Changes

  • Replaced Vuetify components (VCard, VLayout, VChip, VTooltip) with KDS equivalents
  • KImg with 16:9 aspect ratio for thumbnails + placeholder

Testing

  • 41 tests passing (StudioDetailsPanel: 28, StudioDetailsRow: 13)
  • Data-present vs data-absent scenarios for all fields
  • Following VTL best practices - user-facing behavior only

Screen-Recording:

Channel.details.modal.mp4

References

fixes : #5530

Reviewer guidance

  1. Check RTL language support
  2. Run unit tests: npm test StudioChip StudioDetailsRow StudioDetailsPanel

@vtushar06 vtushar06 force-pushed the fix/channel-details-in-channel branch from 61e0727 to 5c41386 Compare November 7, 2025 11:04
@MisRob MisRob changed the title Fix/channel details in channel [Remove Vuetify from Studio] Channel details in Channels - content Nov 11, 2025
@MisRob
Copy link
Member

MisRob commented Nov 11, 2025

Hi @vtushar06, thank you. As for the structure of components, and very high-level, looks as expected 👍

Before we dive into full review though, let's revisit approach to testing. This will help a reviewer too - they will be able to recognize whether the logic behaves as expected for channels with/without all sorts of data.

Also, the guidance I left is quite general. I know you have more PRs open - would you please check if there are some similar patterns to be addressed there as well?

@vtushar06
Copy link
Contributor Author

Hii @MisRob,
I’ve updated the tests to Tests and refined them so they now only check what actually matters.
Please let me know if this looks good to you or if anything else needs to be adjusted.

@vtushar06
Copy link
Contributor Author

One more thing when I tested this in 'rtl' I can see that notranslate class doesn't follow that on official website and same on localhost, what should I do to that??

@MisRob
Copy link
Member

MisRob commented Nov 18, 2025

Hi @vtushar06,

We will assign reviewer here week or two later, some time after we've merged few other PRs, one of them yours, that will be good to have in place before we check these changes.

Meanwhile you can revisit:

(1) The use of stubs and possible simplification of the test suite setup according to notes I left today on your other PRs, if relevant.

(2) As for your note:

Data-present vs data-absent scenarios for all fields.

I don't yet see this in StudioDetailsPanel.spec.js - would definitely be helpful since this component has lots of conditional logic. This will take some effort - take your time.

@MisRob
Copy link
Member

MisRob commented Nov 18, 2025

One more thing when I tested this in 'rtl' I can see that notranslate class doesn't follow that on official website and same on localhost, what should I do to that??

I don't quite understand the question - would you post a screenshot, or rephrase?

@MisRob
Copy link
Member

MisRob commented Nov 19, 2025

Hi @vtushar06, I wanted to mention that I've just merged another PR that introduces StudioChip and I think it'd be best to re-use the existing implementation rather than having two components. Sorry for this timing, I didn't realize it was already work in progress elsewhere when I assigned you this issue.

I think it'd be easiest if you rebased this PR on top of the latest unstable branch, and then fully accept the incoming unstable's StudioChip, and use it for your work here, rather than adding new one. No worries about slightly different round corners - just use StudioChip as is and then we will see if some adjustments are needed. This will also resolve the conflict.

@vtushar06 vtushar06 force-pushed the fix/channel-details-in-channel branch from f5d6f31 to 5600ff2 Compare November 20, 2025 04:39
@vtushar06 vtushar06 force-pushed the fix/channel-details-in-channel branch from ba4add6 to ff8e9e0 Compare November 20, 2025 05:20
@vtushar06
Copy link
Contributor Author

Hi @MisRob, I've completed all the requested changes - tests now follow VTL principles with data-present/absent scenarios, and I'm using the contributor's StudioChip from unstable. About RTL/notranslate: The notranslate class is for excluding user content from translation services, not for text direction. The dir="auto" attribute handles RTL direction. Is this the expected behavior? and all 41 tests passing. Now it is ready for review .

@vtushar06 vtushar06 requested a review from MisRob November 20, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Channel details in Channels - content

2 participants