-
Notifications
You must be signed in to change notification settings - Fork 254
[Remove Vuetify from Studio] Channel details in Channels - page layout #5510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Channel details in Channels - page layout #5510
Conversation
…siveModal in ChannelDetailsModal
…ructure and styling
|
Hii @MisRob,question about layout: Using
Let me know your preference! Thanks! |
|
Hi @vtushar06, I think it'd be meaningful to remove In this way, we will be able to use Note that there are few other places where |
… structure; enhance ChannelDetailsModal tests for better clarity and functionality
16caaa3 to
3ced5cf
Compare
…proved visibility
1453e81 to
c2a3e42
Compare
|
Hi @MisRob, |
|
I wanted to confirm the intended behavior: I’ve added |
|
@vtushar06 we won't do any changes to user experience unless explicitly mentioned in the issue - it's not the goal of this project, and we have internal processes that would need to precede such decisions. So please stay as close as possible to the current experience. |
|
okay sure @MisRob, I thought in sake for UX, reverting back the changes to use current experience, thanks for this guidance too. |
3ccd761 to
5437d8a
Compare
|
Hii @MisRob, I have updated inner page to use previous codes, I think now you can review this out whenever possible and let me know if any further changes required to update. |
|
Thanks for you understanding @vtushar06 - it's definitely good that you think about how to improve user experience - I just need to work within the scope of this project ;) |
|
Hi @vtushar06, just following-up - I plan to review this PR next week. I posted few notes on your other PRs and some of them were quite general, so meanwhile you can see if any of them apply here as well. |
|
Hii @MisRob, I rechecked all my changes, Now you can proceed with review.Thanks |
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vtushar06, thank you. Looks pretty good overall. I'm leaving some notes and few questions.
In my localhost preview, I noticed these three areas that need to be addressed:
contentcuration/contentcuration/frontend/shared/views/StudioImmersiveModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioImmersiveModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioImmersiveModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioImmersiveModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioImmersiveModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/channel/ChannelDetailsModal.vue
Outdated
Show resolved
Hide resolved
...curation/contentcuration/frontend/shared/views/channel/__tests__/channelDetailsModal.spec.js
Show resolved
Hide resolved
...curation/contentcuration/frontend/shared/views/channel/__tests__/channelDetailsModal.spec.js
Outdated
Show resolved
Hide resolved
...curation/contentcuration/frontend/shared/views/channel/__tests__/channelDetailsModal.spec.js
Outdated
Show resolved
Hide resolved
...curation/contentcuration/frontend/shared/views/channel/__tests__/channelDetailsModal.spec.js
Outdated
Show resolved
Hide resolved
REC-20251118150809.mp4Hi @MisRob, |
…date ChannelDetailsModal tests for better clarity and functionality
|
The recording looks good @vtushar06, I will re-review. Can you have a look at why tests are failing? |
|
Hi @MisRob, I've analyzed the test failures and found that the tests are looking for data-testid="loader" and data-testid="details-panel", but these attributes don't exist on the StudioLargeLoader and DetailsPanel components. The components are rendering correctly (I can see them in the DOM output), but the test selectors don't match. This appears to be a pre-existing issue with the test setup,may be these are not related to our Vuetify- KDS migration. What would be the best approach to fix this? |
|
@vtushar06 I don't understand fully what you're trying to say around pre-existing issue, but I don't see a problem with adding test IDs as needed. E.g. |
|
you're right, my apologies for the confusion. I understand now - since I added StudioLargeLoader in this PR, it's my job to make sure it has the test IDs tests need. I've now added data-testid="loader" to it. Thanks for clarifying. |
|
Now PR is ready to get final review. |
Summary
Migrates
ChannelDetailsModalfrom Vuetify to Kolibri Design System by creating a newStudioImmersiveModalcomponent.Changes:
StudioImmersiveModal.vue- Fullscreen modal using KToolbar and KIconButton (no Vuetify dependencies)ChannelDetailsModal.vue:FullscreenModalwithStudioImmersiveModalKButton+KDropdownMenuLoadingTextwithStudioLargeLoaderDetailsPanelunchanged per requirementsScreenshots:
References
Closes: #5474
…
Reviewer guidance
Quick Test:
pnpm install && pnpm run devserver:hota@a.com/aKey Test Cases:
pnpm run devserver)