Renames dupilicate recommendations endpoint names#5506
Merged
bjester merged 2 commits intolearningequality:hotfixesfrom Oct 27, 2025
Merged
Renames dupilicate recommendations endpoint names#5506bjester merged 2 commits intolearningequality:hotfixesfrom
bjester merged 2 commits intolearningequality:hotfixesfrom
Conversation
bjester
approved these changes
Oct 27, 2025
Member
bjester
left a comment
There was a problem hiding this comment.
Code is decently tested and tests have been updated. Observed no issues in testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the recommendation event endpoints to
api/events/recommendations,api/events/recommendationsinteraction, andapi/events/flagged, depending on the event type. This new structure lays the groundwork for supporting additional event types beyond search recommendations. The search recommendations endpoint remains unchanged asapi/recommendations.References
Fixes #5212
Reviewer guidance